liyafan82 commented on a change in pull request #2146:
URL: https://github.com/apache/calcite/pull/2146#discussion_r487628337



##########
File path: core/src/test/java/org/apache/calcite/test/RelMetadataTest.java
##########
@@ -918,6 +918,28 @@ private void checkRelSelectivity(
 
   @Test void testDistinctRowCountTable() {
     // no unique key information is available so return null
+    RelNode rel = convertSql("select * from (values "
+        + "(1, 2, 3), "
+        + "(3, 4, 5), "
+        + "(3, 4, 5), "
+        + "(8, 4, 5) "
+        + ") t(c1, c2, c3)");
+    final RelMetadataQuery mq = rel.getCluster().getMetadataQuery();
+
+    ImmutableBitSet groupKey = ImmutableBitSet.of(0, 1, 2);

Review comment:
       Sure. Cases for null literals are added. Thanks for your good 
suggestion. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to