amaliujia commented on a change in pull request #2151:
URL: https://github.com/apache/calcite/pull/2151#discussion_r489898308
##########
File path: core/src/main/java/org/apache/calcite/rex/RexBuilder.java
##########
@@ -1359,7 +1359,7 @@ public RexNode makeBetween(RexNode arg, RexNode lower,
RexNode upper) {
/** Converts a list of expressions to a search argument, or returns null if
* not possible. */
private static <C extends Comparable<C>> Sarg<C> toSarg(Class<C> clazz,
- List<? extends RexNode> ranges, boolean containsNull) {
+ RelDataType type, List<? extends RexNode> ranges, boolean containsNull) {
Review comment:
As you are modifying this signature, could you update the java doc to
document what theses parameters are?
This will help understand why need a type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
