Aaaaaaron edited a comment on pull request #2161:
URL: https://github.com/apache/calcite/pull/2161#issuecomment-696535352


   > Remove the word 'fix' from the commit message. Change the message so that 
it is clear what the bug is.
   > 
   > Add space before '(' in commit message.
   > 
   > Why would `DECIMAL(10, 15)` not be valid? Say if you are measuring a small 
quantify such as the [Gravitational 
constant](https://en.wikipedia.org/wiki/Gravitational_constant), 6.674 * 10-11.
   
   Hi Julian, Roger the message irregular, will refine latter.
   
   From my understanding, precision represents the total number of digits that 
can be represented by the column, so it must >= than scale.
   `DECIMAL(15, 10)` means that the total number of digits is 15, and the 
decimal place is 10(in other words, the number of integer place is 5).
   
   If you execute `create table test (a decimal(1,3));`, will occur error: 
`Schema Error: Error: ER_M_BIGGER_THAN_D: For float(M,D), double(M,D) or 
decimal(M,D), M must be >= D (column 'a').`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to