rubenada commented on a change in pull request #2168:
URL: https://github.com/apache/calcite/pull/2168#discussion_r494306848
##########
File path: core/src/test/java/org/apache/calcite/test/RelMetadataTest.java
##########
@@ -1618,20 +1619,23 @@ private void checkCollation(RelOptCluster cluster,
RelOptTable empTable,
final EnumerableMergeJoin join;
join = EnumerableMergeJoin.create(project, deptSort,
rexBuilder.makeLiteral(true), leftKeys, rightKeys, JoinRelType.INNER);
+ assertThat(join.getTraitSet().getConvention(),
equalTo(EnumerableConvention.INSTANCE));
Review comment:
I'd prefer to keep it in the unit test, so that we can detect any
potential regression in the future.
Also, I like the idea of systematically adding a new test scenario every
time we encounter an issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
