liupc commented on a change in pull request #2171:
URL: https://github.com/apache/calcite/pull/2171#discussion_r495983718
##########
File path: core/src/main/java/org/apache/calcite/sql/type/SqlTypeUtil.java
##########
@@ -123,21 +126,13 @@ public static boolean isCharTypeComparable(
SqlCallBinding binding,
List<SqlNode> operands,
boolean throwOnFailure) {
- final SqlValidator validator = binding.getValidator();
- final SqlValidatorScope scope = binding.getScope();
- assert operands != null;
- assert operands.size() >= 2;
+ requireNonNull(operands, "operands");
+ assert operands.size() >= 2
Review comment:
> assert operands.size() >= 2 does not seem to have a corresponding Java
API.
I agree that we should keep the scope of this PR minimal and clear, and
maybe rework the `assert` in another PR,
but regrading to the above comments, I think we can use the guava's
`Preconditions.checkArgument` to do this check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
