jamesstarr commented on a change in pull request #2172:
URL: https://github.com/apache/calcite/pull/2172#discussion_r495616031
##########
File path:
core/src/main/java/org/apache/calcite/rel/metadata/RelMdAllPredicates.java
##########
@@ -204,10 +202,10 @@ public RelOptPredicateList getAllPredicates(Join join,
RelMetadataQuery mq) {
currentTablesMapping.put(rightRef,
RelTableRef.of(rightRef.getTable(), shift +
rightRef.getEntityNumber()));
}
- final List<RexNode> updatedPreds = Lists.newArrayList(
- Iterables.transform(inputPreds.pulledUpPredicates,
+ final List<RexNode> updatedPreds =
Review comment:
This is a change in behavior. Did you mean to drop Lists.newArrayList?
You could replace this with a stream.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
