hbtoo commented on a change in pull request #2187:
URL: https://github.com/apache/calcite/pull/2187#discussion_r502819155
##########
File path:
core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java
##########
@@ -906,6 +904,62 @@ void rename(RelNode rel) {
}
}
+ /**
+ * Checks whether a relexp has made any subset cheaper, and if it so,
+ * propagate new cost to parent rel nodes.
+ *
+ * @param planner Planner
+ * @param mq Metadata query
+ * @param rel Relational expression whose cost has improved
+ */
+ void propagateCostImprovements(VolcanoPlanner planner,
Review comment:
good point, removed
##########
File path:
core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java
##########
@@ -906,6 +904,62 @@ void rename(RelNode rel) {
}
}
+ /**
+ * Checks whether a relexp has made any subset cheaper, and if it so,
+ * propagate new cost to parent rel nodes.
+ *
+ * @param planner Planner
+ * @param mq Metadata query
+ * @param rel Relational expression whose cost has improved
+ */
+ void propagateCostImprovements(VolcanoPlanner planner,
+ RelMetadataQuery mq, RelNode rel) {
Review comment:
good point, removed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
