danny0405 commented on a change in pull request #2187:
URL: https://github.com/apache/calcite/pull/2187#discussion_r502859342
##########
File path: core/src/main/java/org/apache/calcite/plan/volcano/RelSet.java
##########
@@ -413,14 +411,9 @@ void mergeWith(
// calls propagateCostImprovements() for RelSubset instances,
// whose best should be changed to check whether that
// subset's parents get cheaper.
- Set<RelSubset> activeSet = new HashSet<>();
for (Map.Entry<RelSubset, RelNode> subsetBestPair :
changedSubsets.entrySet()) {
- RelSubset relSubset = subsetBestPair.getKey();
Review comment:
The `changedSubsets` keys are never used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
