aryeh-looker commented on a change in pull request #2210:
URL: https://github.com/apache/calcite/pull/2210#discussion_r503604135



##########
File path: core/src/main/java/org/apache/calcite/sql/SqlJdbcFunctionCall.java
##########
@@ -752,6 +752,7 @@ private JdbcToInternalLookupTable() {
               return super.createCall(pos, operands);
             }
           });
+      map.put("COUNTIF", simple(SqlLibraryOperators.COUNTIF));

Review comment:
       We likely could implement calcite support for this function, as opposed 
to merely using `simple`. Not sure on convention — i.e. if changes like this 
are accepted upstream for mere parseability.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to