shlok7296 commented on a change in pull request #2201:
URL: https://github.com/apache/calcite/pull/2201#discussion_r503751061
##########
File path:
elasticsearch/src/main/java/org/apache/calcite/adapter/elasticsearch/PredicateAnalyzer.java
##########
@@ -982,15 +1022,15 @@ private static void
checkForIncompatibleDateTimeOperands(RexCall call) {
RelDataType op1 = call.getOperands().get(0).getType();
RelDataType op2 = call.getOperands().get(1).getType();
if ((SqlTypeFamily.DATETIME.contains(op1) &&
!SqlTypeFamily.DATETIME.contains(op2))
- || (SqlTypeFamily.DATETIME.contains(op2) &&
!SqlTypeFamily.DATETIME.contains(op1))
- || (SqlTypeFamily.DATE.contains(op1) &&
!SqlTypeFamily.DATE.contains(op2))
- || (SqlTypeFamily.DATE.contains(op2) &&
!SqlTypeFamily.DATE.contains(op1))
- || (SqlTypeFamily.TIMESTAMP.contains(op1) &&
!SqlTypeFamily.TIMESTAMP.contains(op2))
- || (SqlTypeFamily.TIMESTAMP.contains(op2) &&
!SqlTypeFamily.TIMESTAMP.contains(op1))
- || (SqlTypeFamily.TIME.contains(op1) &&
!SqlTypeFamily.TIME.contains(op2))
- || (SqlTypeFamily.TIME.contains(op2) &&
!SqlTypeFamily.TIME.contains(op1))) {
+ || (SqlTypeFamily.DATETIME.contains(op2) &&
!SqlTypeFamily.DATETIME.contains(op1))
+ || (SqlTypeFamily.DATE.contains(op1) &&
!SqlTypeFamily.DATE.contains(op2))
Review comment:
As we have added an inner switch case conditions thats y these
indentation changes were required otherwise it was failing due to checkstyle
errors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
