julianhyde commented on a change in pull request #2202:
URL: https://github.com/apache/calcite/pull/2202#discussion_r506052011
##########
File path: core/src/main/java/org/apache/calcite/adapter/jdbc/JdbcRules.java
##########
@@ -196,7 +196,10 @@ private JdbcRules() {
};
/** A {@link RelBuilderFactory} that creates a {@link RelBuilder} that will
- * create JDBC relational expressions for everything. */
+ * create JDBC relational expressions for everything.
+ * @deprecated very few factories are implemented, so refrain from using them
+ **/
+ @Deprecated
Review comment:
Please use '*/' rather than '**/'.
Make it clear that we have no plans to remove this builder. Just that if you
use it, you should expect to have to fix some bugs and write some tests. (The
factories are private, so the comment should be about the builder, not the
factories.)
The ideal is that someone uses this, fixes some bugs and gets it to
production quality. Let's write the comment to facilitate that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
