Aaaaaaron commented on a change in pull request #2225:
URL: https://github.com/apache/calcite/pull/2225#discussion_r508169983
##########
File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java
##########
@@ -3825,7 +3825,8 @@ public boolean test(Project project) {
+ " sum(case when deptno = 10 then sal end) as sum_sal_d10,\n"
+ " sum(case when deptno = 20 then sal else 0 end) as sum_sal_d20,\n"
+ " sum(case when deptno = 30 then 1 else 0 end) as count_d30,\n"
- + " count(case when deptno = 40 then 'x' end) as count_d40,\n"
+ + " sum(case when deptno = 40 then 1 end) as count_d40,\n"
Review comment:
> alias is `count` but the function is `sum`
See above `" sum(case when deptno = 30 then 1 else 0 end) as count_d30,\n"`,
I followed this.
"SUM CASE WHEN Then 1" means count, under my understanding.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
