danny0405 commented on a change in pull request #2228:
URL: https://github.com/apache/calcite/pull/2228#discussion_r510576544
##########
File path: core/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java
##########
@@ -2962,4 +2970,23 @@ assert allLessThan(this.oldToNewOutputs.values(),
/** Sets {@link #decorrelator}. */
Config withDecorrelator(RelDecorrelator decorrelator);
}
+
+ // -------------------------------------------------------------------------
+ // Getter/Setter
+ // -------------------------------------------------------------------------
+
+ /**
+ * Returns the {@code visitor} on which the {@code MethodDispatcher}
dispatches
+ * each {@code decorrelateRel} method, the default implementation returns
this instance,
+ * if you got a sub-class, override this method to replace the {@code
visitor} as the
+ * sub-class instance.
+ */
+ protected RelDecorrelator getVisitor() {
+ return this;
+ }
+
+ /** Returns the rules applied on the rel after decorrelation, never null. */
+ protected Collection<RelOptRule> getPostDecorrelateRules() {
Review comment:
No, because `@NotNull` should be the default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
