vlsi commented on a change in pull request #1929:
URL: https://github.com/apache/calcite/pull/1929#discussion_r510634360



##########
File path: core/src/main/java/org/apache/calcite/DataContext.java
##########
@@ -42,17 +44,17 @@
   /**
    * Returns a sub-schema with a given name, or null.
    */
-  SchemaPlus getRootSchema();
+  @Nullable SchemaPlus getRootSchema();
 
   /**

Review comment:
       `javax.annotation.Nullable` does not support cases like 
`List<javax.annotation.Nullable String>`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to