chunweilei commented on a change in pull request #2224:
URL: https://github.com/apache/calcite/pull/2224#discussion_r510702256
##########
File path: core/src/main/java/org/apache/calcite/plan/RelOptUtil.java
##########
@@ -2199,13 +2199,57 @@ public static boolean equal(
RelDataType type2,
Litmus litmus) {
if (!areRowTypesEqual(type1, type2, false)) {
- return litmus.fail("Type mismatch:\n{}:\n{}\n{}:\n{}",
+ return litmus.fail("Type mismatch:\n{}:\n{}\n{}:\n{}\ndifference:\n{}",
desc1, type1.getFullTypeString(),
- desc2, type2.getFullTypeString());
+ desc2, type2.getFullTypeString(),
+ getFullTypeDifferenceString(type1, type2));
}
return litmus.succeed();
}
+ public static String getFullTypeDifferenceString(RelDataType source,
+ RelDataType target) {
+ if (source == target) {
+ return "";
+ }
+
+ final int sourceFieldCount = source.getFieldCount();
+ final int targetFieldCount = target.getFieldCount();
+ if (sourceFieldCount != targetFieldCount) {
+ return "Type mismatch: the field size of source and target are not
equal, "
+ + "the source type has " + sourceFieldCount + " fields, "
+ + "while the target type has " + targetFieldCount + " fields";
Review comment:
@vlsi If the size is not equal, the user should fix it first. Then the
user would know the difference if the types are not equal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
