julianhyde commented on a change in pull request #2229: URL: https://github.com/apache/calcite/pull/2229#discussion_r511029424
########## File path: site/_docs/howto.md ########## @@ -990,6 +992,12 @@ address. You can use [the 1.20.0 announcement](https://mail-archives.apache.org/mod_mbox/www-announce/201906.mbox/%3CCA%2BEpF8tcJcZ41rVuwJODJmyRy-qAxZUQm9OxKsoDi07c2SKs_A%40mail.gmail.com%3E) as a template. Be sure to include a brief description of the project. +Finally, increase the `calcite.version` value in `/gradle.properties` and commit & push +the change with the message "Prepare for next development iteration". + +Send an email to [[email protected]](mailto:[email protected]) notifying +that `master` code freeze is over and commits can resume. Review comment: Change to 'Re-open the master branch. Send an email ...'. Documentation is clearer if you lead with the purpose/high-level action. ########## File path: site/_docs/howto.md ########## @@ -684,8 +684,14 @@ Note: release artifacts (dist.apache.org and repository.apache.org) are managed Before you start: +* Send an email to [[email protected]](mailto:[email protected]) notifying that RC build process + is starting and therefore `master` branch is in code freeze until further notice. * Set up signing keys as described above. +* Upload your key to [https://keyserver.ubuntu.com](https://keyserver.ubuntu.com) and/or + [http://pool.sks-keyservers.net:11371](http://pool.sks-keyservers.net:11371) (keyservers used by Nexus). Review comment: Move the 'upload your key' to the 'set up signing keys' section. Maybe add a troubleshooting point 'If xxx happens make sure that you uploaded your key to ubuntu'. ########## File path: site/_docs/howto.md ########## @@ -990,6 +992,12 @@ address. You can use [the 1.20.0 announcement](https://mail-archives.apache.org/mod_mbox/www-announce/201906.mbox/%3CCA%2BEpF8tcJcZ41rVuwJODJmyRy-qAxZUQm9OxKsoDi07c2SKs_A%40mail.gmail.com%3E) as a template. Be sure to include a brief description of the project. +Finally, increase the `calcite.version` value in `/gradle.properties` and commit & push Review comment: Give an example commit that people can cherry-pick. ########## File path: site/_docs/howto.md ########## @@ -684,8 +684,14 @@ Note: release artifacts (dist.apache.org and repository.apache.org) are managed Before you start: +* Send an email to [[email protected]](mailto:[email protected]) notifying that RC build process + is starting and therefore `master` branch is in code freeze until further notice. * Set up signing keys as described above. +* Upload your key to [https://keyserver.ubuntu.com](https://keyserver.ubuntu.com) and/or + [http://pool.sks-keyservers.net:11371](http://pool.sks-keyservers.net:11371) (keyservers used by Nexus). * Make sure you are using JDK 8 (not 9 or 10). +* Make sure `master` branch and `site` branch are in sync, i.e. there is no commit on `site` that has not + been applied also to `master`. If this the case, cherry-pick the missing commit(s) into `master`. Review comment: You can check by doing something like 'git checkout site; git rebase -i master'. ########## File path: site/_docs/howto.md ########## @@ -990,6 +992,12 @@ address. You can use [the 1.20.0 announcement](https://mail-archives.apache.org/mod_mbox/www-announce/201906.mbox/%3CCA%2BEpF8tcJcZ41rVuwJODJmyRy-qAxZUQm9OxKsoDi07c2SKs_A%40mail.gmail.com%3E) as a template. Be sure to include a brief description of the project. +Finally, increase the `calcite.version` value in `/gradle.properties` and commit & push Review comment: Remove 'finally'. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
