julianhyde commented on a change in pull request #2225:
URL: https://github.com/apache/calcite/pull/2225#discussion_r511045898
##########
File path:
core/src/main/java/org/apache/calcite/rel/rules/AggregateCaseToFilterRule.java
##########
@@ -227,8 +227,11 @@ protected AggregateCaseToFilterRule(RelBuilderFactory
relBuilderFactory,
RelCollations.EMPTY, aggregateCall.getType(),
aggregateCall.getName());
} else if (kind == SqlKind.SUM // Case B
- && isIntLiteral(arg1) && RexLiteral.intValue(arg1) == 1
- && isIntLiteral(arg2) && RexLiteral.intValue(arg2) == 0) {
+ && isIntLiteral(arg1)
+ && RexLiteral.intValue(arg1) == 1
+ && isIntLiteral(arg2)
+ && !RexLiteral.isNullLiteral(arg2)
Review comment:
The previous code, with two conditions per line, made the logic really
clear:
```
&& isIntLiteral(arg1) && RexLiteral.intValue(arg1) == 1
&& isIntLiteral(arg2) && RexLiteral.intValue(arg2) == 0
```
We just weren't handling some details about null values and - as @vlsi
points out - values outside the int range. Let's go back to the old structure.
Make the necessary changes to `isIntLiteral` to deal with the corner cases.
It's private so you can do what you need to.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
