asolimando commented on a change in pull request #2230:
URL: https://github.com/apache/calcite/pull/2230#discussion_r512478226
##########
File path: core/src/main/java/org/apache/calcite/sql/fun/SqlItemOperator.java
##########
@@ -115,7 +115,8 @@ private SqlSingleOperandTypeChecker
getChecker(SqlCallBinding callBinding) {
@Override public String getAllowedSignatures(String name) {
return "<ARRAY>[<INTEGER>]\n"
- + "<MAP>[<VALUE>]";
+ + "<MAP>[<VALUE>]\n"
+ + "<ROW>[<CHARACTER>|<INTEGER>]";
}
Review comment:
`VALUE` makes sense for `MAP` as it stands for the value for the
datatype used for the key of the map itself (which is not known a priori), for
`ROW`, very much like for `ARRAY`, we know the types for our index operand, so
it's better to refer to them explicitly IMO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
