danny0405 commented on a change in pull request #2222:
URL: https://github.com/apache/calcite/pull/2222#discussion_r514808226
##########
File path:
core/src/main/java/org/apache/calcite/plan/volcano/VolcanoRuleCall.java
##########
@@ -190,7 +190,8 @@ protected void onMatch() {
return;
}
- if (subset.set.equivalentSet != null) {
+ if ((subset.set.equivalentSet != null)
+ || (subset != rel && !subset.getRelList().contains(rel))) {
Review comment:
The operation `subset.getRelList().contains(rel)` is with poor
performance. Can you give evidence how much gains of the patch ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
