julianhyde commented on a change in pull request #2238:
URL: https://github.com/apache/calcite/pull/2238#discussion_r516228159
##########
File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java
##########
@@ -2710,6 +2710,16 @@ private boolean accept1(RexNode e, SqlKind kind,
}
}
+ /** Checks whether it is worth to fix and convert to {@code SEARCH} calls.
*/
Review comment:
s/Checks/Returns/; "Checks" often means that the method will throw if
the check fails, whereas "Returns" is unambiguous.
Put the criteria in the javadoc, and describe the purpose of `newTermsCnt`.
I wouldn't abbreviate `count` to `cnt`. Save to characters, but convert a
word into a non-word.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
