zabetak commented on a change in pull request #2223:
URL: https://github.com/apache/calcite/pull/2223#discussion_r515817104
##########
File path:
core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java
##########
@@ -239,6 +239,12 @@
public static final CalciteSystemProperty<Boolean> TEST_REDIS =
booleanProperty("calcite.test.redis", true);
+ /**
+ * Whether to use Docker with TestContainers
(https://www.testcontainers.org/) when available
+ */
+ public static final CalciteSystemProperty<Boolean>
TEST_WITH_DOCKER_CONTAINER =
+ booleanProperty("calcite.test.docker", true);
+
Review comment:
What's the benefit of having this property?
If Docker is available we can run the tests, if not then either we skip them
or fallback to another execution method.
##########
File path:
redis/src/test/java/org/apache/calcite/adapter/redis/RedisCaseBase.java
##########
@@ -36,16 +43,33 @@
public static final String HOST = "127.0.0.1";
private static final String MAX_HEAP = "maxheap 51200000";
+ // If Docker is running, a container will be used
+ public static final GenericContainer<?> REDIS_CONTAINER =
+ new GenericContainer<>("redis").withExposedPorts(6379);
Review comment:
I agree, let's freeze the version ideally using the same that is present
in the gradle.properties.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
