danny0405 edited a comment on pull request #2238: URL: https://github.com/apache/calcite/pull/2238#issuecomment-721613490
> I believe the logic with `needToFix` makes no sense. Sarg replacement should be on per-sarg basis rather than "all or nothing" I'm not sure, because the Sarg structure as a intermediate can make more simplification possibilities. So when there are fix condition match, it does not harm to try to make each term as a `SEARCH` `Sarg` if possible. But anyway, the logic is already there and this PR is an improvement. So i would merge it soon. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
