danny0405 commented on pull request #2238: URL: https://github.com/apache/calcite/pull/2238#issuecomment-722188731
> @danny0405 , before you commit more fixes to `RexSimplify` could I kindly ask you to review the regression which was introduced a year ago https://issues.apache.org/jira/browse/CALCITE-3457?focusedCommentId=17224481&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17224481 ? > > You've committed [CALCITE-3457](https://issues.apache.org/jira/browse/CALCITE-3457) and it turns out to cause AssertionErrors on certain inputs. > Would you please fix or revert 3457 before you proceed with committing more changes to RexSimplify? > > ``` > java.lang.AssertionError > at org.apache.calcite.rex.RexSimplify.validateStrongPolicy(RexSimplify.java:903) > at org.apache.calcite.rex.RexSimplify.simplifyIs2(RexSimplify.java:746) > at org.apache.calcite.rex.RexSimplify.simplifyIs1(RexSimplify.java:713) > at org.apache.calcite.rex.RexSimplify.simplifyIs(RexSimplify.java:684) > at org.apache.calcite.rex.RexSimplify.simplify(RexSimplify.java:295) > at org.apache.calcite.rex.RexSimplify.simplifyOrTerms(RexSimplify.java:567) > at org.apache.calcite.rex.RexSimplify.simplifyOr(RexSimplify.java:1771) > at org.apache.calcite.rex.RexSimplify.simplify(RexSimplify.java:276) > at org.apache.calcite.rex.RexSimplify.simplifyComparison(RexSimplify.java:368) > at org.apache.calcite.rex.RexSimplify.simplifyComparison(RexSimplify.java:345) > at org.apache.calcite.rex.RexSimplify.simplify(RexSimplify.java:302) > at org.apache.calcite.rex.RexSimplify.simplifyUnknownAs(RexSimplify.java:243) > at org.apache.calcite.rex.RexProgramTestBase.checkSimplify3_(RexProgramTestBase.java:134) > at org.apache.calcite.rex.RexProgramTestBase.checkSimplify(RexProgramTestBase.java:93) > at org.apache.calcite.rex.RexProgramTest.reproducerFor3457(RexProgramTest.java:514) > ``` This bug was not a blocker of this one, i don't think we should fix it first before this patch. And this is open community, everyone can contribute if they have time to, although i'm the code reviewer, it does not mean i "have to" fix the bug and on one can ensure that he always commits no-bug codes. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
