vlsi commented on a change in pull request #2253:
URL: https://github.com/apache/calcite/pull/2253#discussion_r519462734



##########
File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java
##########
@@ -1688,6 +1690,108 @@ RexNode simplifyAnd2ForUnknownAsFalse(List<RexNode> 
terms,
       return e;
     }
   }
+  
+  public RexNode simplifyBoolean(RexNode call) {

Review comment:
       Can you clarify how this differs from existing `simplifyOr...` and 
`simplifyAnd..` methods?

##########
File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java
##########
@@ -1688,6 +1690,108 @@ RexNode simplifyAnd2ForUnknownAsFalse(List<RexNode> 
terms,
       return e;
     }
   }
+  
+  public RexNode simplifyBoolean(RexNode call) {

Review comment:
       Can you clarify how this differs from the existing `simplifyOr...` and 
`simplifyAnd..` methods?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to