vlsi commented on a change in pull request #2256:
URL: https://github.com/apache/calcite/pull/2256#discussion_r521978173
##########
File path: core/src/test/java/org/apache/calcite/sql/type/SqlTypeUtilTest.java
##########
@@ -197,4 +198,35 @@ private RelDataType struct(RelDataType...relDataTypes) {
}
return builder.build();
}
+
+ private void compareTypesIgnoringNullability(
+ RelDataType type1, RelDataType type2, boolean expectedResult) {
+ String msg = String.format(Locale.ROOT,
+ "%s and %s are expected to be %s ignoring nullability.",
+ type1.getFullTypeString(),
+ type2.getFullTypeString(),
+ expectedResult ? "equal" : "unequal");
+
Review comment:
Another issue here is that **both** asserts have the same message, so it
is hard to tell which fails.
I would suggest:
```java
assertThat(
"SqlTypeUtil.equalSansNullability(typeFactory, " + type1 + ", " +
type2 + "), comment: " + comment,
SqlTypeUtil.equalSansNullability(f.typeFactory, type1, type2),
is(expectedResult));
assertThat(
"SqlTypeUtil.equalSansNullability(" + type1 + ", " + type2 + "),
comment: " + comment,
SqlTypeUtil.equalSansNullability(type1, type2), is(expectedResult));
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
