rubenada commented on a change in pull request #2255:
URL: https://github.com/apache/calcite/pull/2255#discussion_r522006110
##########
File path: core/src/main/java/org/apache/calcite/sql/SqlCallBinding.java
##########
@@ -411,4 +411,8 @@ public CalciteException newValidationError(
public boolean isTypeCoercionEnabled() {
return validator.config().typeCoercionEnabled();
}
+
+ private SqlCall createDefaultCall() {
+ return SqlStdOperatorTable.DEFAULT.createCall(SqlParserPos.ZERO);
Review comment:
Yes... but my fear is that it would be a more "obscure" solution when
looking at this code in the future: "why is this static nested class here, for
apparently no reason, just with a private static field...".
I guess it can be a good (and efficient) solution, but we'll need a clear
javadoc stating the purpose of the class and why it is needed (and cannot be
removed). It should be feasible, I'll commit this approach.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
