rubenada commented on a change in pull request #2266:
URL: https://github.com/apache/calcite/pull/2266#discussion_r525986104
##########
File path: core/src/main/java/org/apache/calcite/sql/SqlCall.java
##########
@@ -153,6 +153,9 @@ public int operandCount() {
if
(!this.getOperator().getName().equalsIgnoreCase(that.getOperator().getName())) {
return litmus.fail("{} != {}", this, node);
}
+ if (!equalDeep(this.getFunctionQuantifier(), that.getFunctionQuantifier(),
litmus)) {
+ return litmus.fail("{} != {} (function qualifier differs)", this, node);
Review comment:
Sorry, the message still uses an incorrect term :
"function **qualifier** differs"
it should be
"function **quantifier** differs"
Also, please add you name between parenthesis at the end of the commit
message, as per https://calcite.apache.org/develop/#contributing _"If you are
not a committer, add your name in parentheses at the end of the message"_
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
