julianhyde commented on a change in pull request #2270:
URL: https://github.com/apache/calcite/pull/2270#discussion_r526317081
##########
File path: core/src/test/java/org/apache/calcite/sql/parser/SqlParserTest.java
##########
@@ -6186,6 +6186,31 @@ public void subTestIntervalDayFailsValidation() {
assertEquals(linux(sqlNodeVisited1.toString()), str1);
}
+ @Test void testSqlDeleteSqlBasicCallToString() throws Exception {
+ final String sql0 = "delete from emps where empno = 1";
+ final SqlNode sqlNode0 = getSqlParser(sql0).parseStmt();
+ final SqlNode sqlNodeVisited0 = sqlNode0.accept(new SqlShuttle() {
+ @Override public SqlNode visit(SqlIdentifier identifier) {
+ return new SqlIdentifier(identifier.names,
+ identifier.getParserPosition());
+ }
+ });
+ final String str0 = "DELETE FROM `EMPS`\n"
+ + "WHERE `EMPNO` = 1";
+ assertEquals(linux(sqlNodeVisited0.toString()), str0);
Review comment:
we don't use assertEquals. because people get the args in the wrong
order. as you did.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]