Aaaaaaron commented on a change in pull request #2274:
URL: https://github.com/apache/calcite/pull/2274#discussion_r528166398
##########
File path:
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java
##########
@@ -3008,6 +3008,12 @@ private void checkLiteral2(String expression, String
expected) {
+ "OVER (PARTITION BY \"hire_date\" ORDER BY \"employee_id\"),
\"hire_date\"\n"
+ "FROM \"foodmart\".\"employee\"\n"
+ "GROUP BY \"hire_date\", \"employee_id\"";
+ String query7 = "SELECT "
+ + "count(distinct \"employee_id\") over (order by \"hire_date\") FROM
\"employee\"";
+ String expected7 = "SELECT "
+ + "COUNT(DISTINCT \"employee_id\") "
+ + "OVER (ORDER BY \"hire_date\" RANGE BETWEEN UNBOUNDED PRECEDING AND
CURRENT ROW) AS \"$0\""
+ + "\nFROM \"foodmart\".\"employee\"";
Review comment:
@danny0405 Hi Danny, seems rel to SQL will print these, if I remove
them, the test failed, maybe we can open a new JIRA to not print out these in
RelToSql.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
