vvysotskyi commented on a change in pull request #2286:
URL: https://github.com/apache/calcite/pull/2286#discussion_r534492431
##########
File path:
core/src/main/java/org/apache/calcite/adapter/jdbc/JdbcToEnumerableConverterRule.java
##########
@@ -30,9 +30,9 @@
*/
public class JdbcToEnumerableConverterRule extends ConverterRule {
/** Creates a JdbcToEnumerableConverterRule. */
- public static JdbcToEnumerableConverterRule create(JdbcConvention out) {
+ public static JdbcToEnumerableConverterRule create(JdbcConvention in) {
Review comment:
This rule applies to relational expressions that have a specified
convention, so I decided to rename it, but I can revert this change if required.
##########
File path: core/src/main/java/org/apache/calcite/adapter/jdbc/JdbcRules.java
##########
@@ -230,14 +231,27 @@ private JdbcRules() {
public static List<RelOptRule> rules(JdbcConvention out,
RelBuilderFactory relBuilderFactory) {
final ImmutableList.Builder<RelOptRule> b = ImmutableList.builder();
+ b.add(JdbcToEnumerableConverterRule.create(out)
Review comment:
I don't think that it will be optimal, the main difference is in the
presence of `withInTrait(in)` call in a builder chain inside the lambda. Such
refactoring will just increase the code complexity.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
