vlsi edited a comment on pull request #2290: URL: https://github.com/apache/calcite/pull/2290#issuecomment-739483716
@Aaaaaaron , it is really sad when the review takes way more time than doing the same thing on my own. This PR has 3 changes: 1) revert 2222. I fully agree 2) map.remove. The change is wrong. 2) checkDuplicateSubsets. The change is wrong. That is really demotivating. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
