chunweilei commented on pull request #2287: URL: https://github.com/apache/calcite/pull/2287#issuecomment-739771391
> -1 on this change. > > As I explained in the JIRA case, it is an internal method, it doesn't need detailed messages. > > The real fix is to createCastRel. @julianhyde, could you please review [https://github.com/chunweilei/calcite/commit/a0ccf9d13da2f47cfacd7dda8a5b9e51f382f2b8] to see whether it is your preference? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
