julianhyde commented on a change in pull request #2292:
URL: https://github.com/apache/calcite/pull/2292#discussion_r538938594
##########
File path: core/src/main/java/org/apache/calcite/plan/RelOptUtil.java
##########
@@ -829,6 +829,9 @@ public static RelNode createNullFilter(
* instead, create a projection with the input of {@code rel} and the new
* cast expressions.
*
+ * <p>The field count of the desired row type and the row type to be
converted
+ * should be equal. Otherwise, it would throw an exception.
+ *
Review comment:
-0 for `throws`. A clear description is sufficient. Redundancy is worse.
I would write 'The desired row type and the row type to be converted must
have the same number of fields.' (Avoids 'should', avoids 'field count of ...'
which is a complex noun-phrase, and is more direct; and doesn't mention that
exceptions are thrown, because we don't want people catching exceptions.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
