asolimando commented on a change in pull request #2296:
URL: https://github.com/apache/calcite/pull/2296#discussion_r544199479
##########
File path:
core/src/main/java/org/apache/calcite/sql2rel/StandardConvertletTable.java
##########
@@ -837,6 +841,44 @@ private static RexNode makeConstructorCall(
return rexBuilder.makeNewInvocation(type, defaultCasts);
}
+ private RexNode convertItem(
+ @UnknownInitialization StandardConvertletTable this,
+ SqlRexContext cx,
+ SqlCall call) {
+ assert call.operandCount() == 2;
Review comment:
I think you are right and the assertion is redundant, the other
preceding steps discussed in a previous comment would already fail with
different number of operands.
I added it in the first place mostly for consistency sake with the rest of
the methods of the same file, so I am fine with dropping it (and very much true
that, as-is, it would not make the life easier for investigating failures).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
