julianhyde commented on a change in pull request #2332:
URL: https://github.com/apache/calcite/pull/2332#discussion_r563033587
##########
File path: core/src/test/java/org/apache/calcite/sql/test/SqlAdvisorTest.java
##########
@@ -1585,4 +1587,17 @@ private void testSimpleParserQuotedIdImpl() {
assertSimplify(sql, simplified);
assertComplete(sql, EXPR_KEYWORDS, Collections.singletonList("TABLE(a)"),
DEPT_COLUMNS);
}
+
+ private static SqlSimpleParser simpleParser =
+ new SqlSimpleParser("_suggest_", SqlParser.Config.DEFAULT);
Review comment:
Make this a local variable, not a static field. Static fields use memory
after the test has finished, and may not be reentrant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
