xwkuang5 commented on a change in pull request #2312:
URL: https://github.com/apache/calcite/pull/2312#discussion_r563743974
##########
File path: core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java
##########
@@ -1212,17 +1212,15 @@ public void _testLikeAndSimilarFails() {
}
@Test void testCastRegisteredType() {
- expr("cast(123 as customBigInt)")
- .fails("class org.apache.calcite.sql.SqlIdentifier: CUSTOMBIGINT");
+ wholeExpr("cast(123 as customBigInt)")
+ .fails("Cast function does not support casting to type
`CUSTOMBIGINT`");
expr("cast(123 as sales.customBigInt)")
Review comment:
Thanks for your review Danny. Based on the discussion in CALCITE-4265, I
am not planning to move forward with this PR. Instead, I created a simpler PR
at https://github.com/apache/calcite/pull/2326. Can you review that one
instead? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
