[GitHub] [calcite] Aaaaaaron commented on pull request #2340: [CALCITE-4482] Extract the default SqlWriterConfig in SqlPrettyWriter, reduce the overhead of "ImmutableBeans.create" (Jiatao Tao)

Tue, 02 Feb 2021 17:04:40 -0800 


Aaaaaaron commented on pull request #2340:
URL: https://github.com/apache/calcite/pull/2340#issuecomment-771424316


   > The failed test seems irrelevant to this PR (i.e. I see the same failed 
check on another PR).
   
   No, just remove the code above the DEFAULT_BEAN, I didn't' see it uses 
config() at first 😂.
   ..


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to