vlsi commented on a change in pull request #2246:
URL: https://github.com/apache/calcite/pull/2246#discussion_r569216086
##########
File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java
##########
@@ -900,13 +902,12 @@ private void validateStrongPolicy(RexNode rexNode) {
case ANY:
List<RexNode> operands = ((RexCall) rexNode).getOperands();
if (rexNode.getType().isNullable()) {
- assert operands.stream()
- .map(RexNode::getType)
- .anyMatch(RelDataType::isNullable);
+ // Ignores the nullability change when all the operands are literals
+ // which come from the simplification.
+ assert
operands.stream().map(RexNode::getType).anyMatch(RelDataType::isNullable)
+ || operands.stream().allMatch(p -> RexUtil.isLiteral(p, false));
Review comment:
`ReduceExpressionsRule.Config.matchNullability` refers to the
nullability of the overall expression rather than the nullability of the
internal nodes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
