jcamachor commented on a change in pull request #2349:
URL: https://github.com/apache/calcite/pull/2349#discussion_r579368274
##########
File path: core/src/main/java/org/apache/calcite/rel/rules/FilterJoinRule.java
##########
@@ -110,10 +110,9 @@ protected void perform(RelOptRuleCall call, @Nullable
Filter filter,
if (RelOptUtil.classifyFilters(
join,
aboveFilters,
- joinType,
- true,
- !joinType.generatesNullsOnLeft(),
- !joinType.generatesNullsOnRight(),
+ joinType.canPushIntoFromAbove(),
Review comment:
Note that the old code was checking internally `if
(!joinType.isOuterJoin() && pushInto) {`. Thus, even if `true` was passed, the
check on the join type was determining whether we were pushing into or not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
