aigor commented on pull request #2357: URL: https://github.com/apache/calcite/pull/2357#issuecomment-785866107
Hi @julianhyde , I run your pull-request through our test suites (in a downstream project). I was not able to detect any serious issues. However, with changes from this pull-request, `RexUtil.expandSearch()` misses the opportunity to simplify some filters. For example, previously the following Rex expression `SEARCH($1, Sarg[[1000..2000]; NULL AS FALSE])` would be expanded to: `AND(>=($1, 1000), <=($1, 2000))`. Now, it is expanded to: `AND(IS NOT NULL($1), AND(>=($1, 1000), <=($1, 2000)))` where additional `IS NOT NULL($1)` is redundant. Definitely, it is not critical but may have affect projects that use `RexUtil.expandSearch()` often. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
