vlsi commented on a change in pull request #2363:
URL: https://github.com/apache/calcite/pull/2363#discussion_r591888771



##########
File path: plus/src/test/java/org/apache/calcite/adapter/tpcds/TpcdsTest.java
##########
@@ -220,9 +220,9 @@ protected void foo(CalciteAssert.AssertThat with, String 
tableName,
         .withHook(Hook.PROGRAM, handler(true, 2))
         .explainMatches("including all attributes ",
             CalciteAssert.checkMaskedResultContains(""
-                + "EnumerableCalc(expr#0..9=[{inputs}], expr#10=[/($t4, $t3)], 
expr#11=[CAST($t10):INTEGER NOT NULL], expr#12=[*($t4, $t4)], expr#13=[/($t12, 
$t3)], expr#14=[-($t5, $t13)], expr#15=[1], expr#16=[=($t3, $t15)], 
expr#17=[null:BIGINT], expr#18=[-($t3, $t15)], expr#19=[CASE($t16, $t17, 
$t18)], expr#20=[/($t14, $t19)], expr#21=[0.5:DECIMAL(2, 1)], 
expr#22=[POWER($t20, $t21)], expr#23=[CAST($t22):INTEGER NOT NULL], 
expr#24=[/($t23, $t11)], expr#25=[/($t6, $t3)], expr#26=[CAST($t25):INTEGER NOT 
NULL], expr#27=[*($t6, $t6)], expr#28=[/($t27, $t3)], expr#29=[-($t7, $t28)], 
expr#30=[/($t29, $t19)], expr#31=[POWER($t30, $t21)], 
expr#32=[CAST($t31):INTEGER NOT NULL], expr#33=[/($t32, $t26)], expr#34=[/($t8, 
$t3)], expr#35=[CAST($t34):INTEGER NOT NULL], expr#36=[*($t8, $t8)], 
expr#37=[/($t36, $t3)], expr#38=[-($t9, $t37)], expr#39=[/($t38, $t19)], 
expr#40=[POWER($t39, $t21)], expr#41=[CAST($t40):INTEGER NOT NULL], 
expr#42=[/($t41, $t35)], proj#0..3=[{exprs}], STORE_SALES_QUANTITY
 AVE=[$t11], STORE_SALES_QUANTITYSTDEV=[$t23], STORE_SALES_QUANTITYCOV=[$t24], 
AS_STORE_RETURNS_QUANTITYCOUNT=[$t3], AS_STORE_RETURNS_QUANTITYAVE=[$t26], 
AS_STORE_RETURNS_QUANTITYSTDEV=[$t32], STORE_RETURNS_QUANTITYCOV=[$t33], 
CATALOG_SALES_QUANTITYCOUNT=[$t3], CATALOG_SALES_QUANTITYAVE=[$t35], 
CATALOG_SALES_QUANTITYSTDEV=[$t42], CATALOG_SALES_QUANTITYCOV=[$t42]): rowcount 
= 100.0, cumulative cost = {1.2435775409784036E28 rows, 2.555295485909236E30 
cpu, 0.0 io}\n"
-                + "  EnumerableLimit(fetch=[100]): rowcount = 100.0, 
cumulative cost = {1.2435775409784036E28 rows, 2.555295485909236E30 cpu, 0.0 
io}\n"
-                + "    EnumerableSort(sort0=[$0], sort1=[$1], sort2=[$2], 
dir0=[ASC], dir1=[ASC], dir2=[ASC]): rowcount = 5.434029018852197E26, 
cumulative cost = {1.2435775409784036E28 rows, 2.555295485909236E30 cpu, 0.0 
io}\n"
+                + "EnumerableCalc(expr#0..9=[{inputs}], expr#10=[/($t4, $t3)], 
expr#11=[CAST($t10):INTEGER NOT NULL], expr#12=[*($t4, $t4)], expr#13=[/($t12, 
$t3)], expr#14=[-($t5, $t13)], expr#15=[1], expr#16=[=($t3, $t15)], 
expr#17=[null:BIGINT], expr#18=[-($t3, $t15)], expr#19=[CASE($t16, $t17, 
$t18)], expr#20=[/($t14, $t19)], expr#21=[0.5:DECIMAL(2, 1)], 
expr#22=[POWER($t20, $t21)], expr#23=[CAST($t22):INTEGER NOT NULL], 
expr#24=[/($t23, $t11)], expr#25=[/($t6, $t3)], expr#26=[CAST($t25):INTEGER NOT 
NULL], expr#27=[*($t6, $t6)], expr#28=[/($t27, $t3)], expr#29=[-($t7, $t28)], 
expr#30=[/($t29, $t19)], expr#31=[POWER($t30, $t21)], 
expr#32=[CAST($t31):INTEGER NOT NULL], expr#33=[/($t32, $t26)], expr#34=[/($t8, 
$t3)], expr#35=[CAST($t34):INTEGER NOT NULL], expr#36=[*($t8, $t8)], 
expr#37=[/($t36, $t3)], expr#38=[-($t9, $t37)], expr#39=[/($t38, $t19)], 
expr#40=[POWER($t39, $t21)], expr#41=[CAST($t40):INTEGER NOT NULL], 
expr#42=[/($t41, $t35)], proj#0..3=[{exprs}], STORE_SALES_QUANTITY
 AVE=[$t11], STORE_SALES_QUANTITYSTDEV=[$t23], STORE_SALES_QUANTITYCOV=[$t24], 
AS_STORE_RETURNS_QUANTITYCOUNT=[$t3], AS_STORE_RETURNS_QUANTITYAVE=[$t26], 
AS_STORE_RETURNS_QUANTITYSTDEV=[$t32], STORE_RETURNS_QUANTITYCOV=[$t33], 
CATALOG_SALES_QUANTITYCOUNT=[$t3], CATALOG_SALES_QUANTITYAVE=[$t35], 
CATALOG_SALES_QUANTITYSTDEV=[$t42], CATALOG_SALES_QUANTITYCOV=[$t42]): rowcount 
= 100.0, cumulative cost = {1.2435775409784036E28 rows, 1.317577974149368E30 
cpu, 0.0 io}\n"
+                + "  EnumerableLimit(fetch=[100]): rowcount = 100.0, 
cumulative cost = {1.2435775409784036E28 rows, 1.317577974149368E30 cpu, 0.0 
io}\n"

Review comment:
       I filed https://github.com/apache/calcite/pull/2368 to remove the cost 
and row attributes from the test




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to