vlsi opened a new pull request #2372: URL: https://github.com/apache/calcite/pull/2372
Matcher#matches is only needed when implementing new Matcher implementations which is very rare. The common test pitfall is assertThat(contains(actual).matches(expected), is(true)) It should better be written as assertThat(actual, contains(expected)) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
