vlsi commented on a change in pull request #2371:
URL: https://github.com/apache/calcite/pull/2371#discussion_r593808777
##########
File path: server/src/test/java/org/apache/calcite/test/ServerTest.java
##########
@@ -532,4 +533,26 @@ static Connection connect() throws SQLException {
}
}
}
+
+ @Test public void testDropWithFullyQualifiedNameWhenSchemaDoesntExist()
throws Exception {
+ try (Connection c = connect();
+ Statement s = c.createStatement()) {
+ checkDropWithFullyQualifiedNameWhenSchemaDoesntExist(s, "schema",
"Schema");
+ checkDropWithFullyQualifiedNameWhenSchemaDoesntExist(s, "table",
"Table");
+ checkDropWithFullyQualifiedNameWhenSchemaDoesntExist(s, "materialized
view", "Table");
+ checkDropWithFullyQualifiedNameWhenSchemaDoesntExist(s, "view", "View");
+ checkDropWithFullyQualifiedNameWhenSchemaDoesntExist(s, "type", "Type");
+ checkDropWithFullyQualifiedNameWhenSchemaDoesntExist(s, "function",
"Function");
+ }
+ }
+
+ private void checkDropWithFullyQualifiedNameWhenSchemaDoesntExist(
+ Statement statement, String objectType, String objectTypeInErrorMessage)
throws Exception {
+ SQLException e = assertThrows(SQLException.class, () ->
+ statement.execute("drop " + objectType + " s.o"),
+ "expected error because the object doesn't exist");
Review comment:
>the parent container doesn’t exist.
That is confusing. Test name says "schema does not exist", and assertion
`reason` says "object does not exist".
Did you intend to add tests for the case when schema exists, yet the object
is missing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
