zabetak commented on pull request #2389:
URL: https://github.com/apache/calcite/pull/2389#issuecomment-816834031


   > LGTM.
   > Maybe we could use this PR to remove the `assert isValid(Litmus.THROW, 
null);` from `LogicalFilter` constructor which seems redundant, since it will 
be already validated by `Filter` when it calls `super`. WDYT?
   
   Good catch @rubenada , totally makes sense! Thanks for taking a look :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to