[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2398: [CALCITE-4583] Make simplification API more conservative in "RelBuilder#filter" (Jiatao Tao)

Thu, 15 Apr 2021 05:06:05 -0700 


Aaaaaaron commented on a change in pull request #2398:
URL: https://github.com/apache/calcite/pull/2398#discussion_r614009314



##########
File path: core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml
##########
@@ -3612,19 +3615,23 @@ join sales.emp e on e.deptno = d.deptno and d.deptno 
not in (4, 6)]]>
         <Resource name="planBefore">
             <![CDATA[
 LogicalProject(EMPNO=[$0], ENAME=[$1], JOB=[$2], MGR=[$3], HIREDATE=[$4], 
SAL=[$5], COMM=[$6], DEPTNO=[$7], SLACKER=[$8], EMPNO0=[$9], ENAME0=[$10], 
JOB0=[$11], MGR0=[$12], HIREDATE0=[$13], SAL0=[$14], COMM0=[$15], 
DEPTNO0=[$16], SLACKER0=[$17])
-  LogicalJoin(condition=[AND(=($16, $7), NOT(OR(=($7, 4), =($7, 6))))], 
joinType=[inner])
-    LogicalTableScan(table=[[CATALOG, SALES, EMP]])
-    LogicalTableScan(table=[[CATALOG, SALES, EMP]])
+  LogicalFilter(condition=[true])

Review comment:
       Hi @zabetak , it these rule, simplification is not on:
   
![image](https://user-images.githubusercontent.com/15643702/114866268-f10be800-9e25-11eb-873a-ef4e75586aa0.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to