julianhyde commented on pull request #2402: URL: https://github.com/apache/calcite/pull/2402#issuecomment-826599546
We don't generally use `System.lineSeparator()`; we generally use "\n" in strings. To make the tests pass in Windows, use `Matchers.isLinux` in your test. The commit message (and JIRA subject) is not clear. Can you improve it? I don't think it will be clear to future maintainers what is the purpose of the two test methods. Please add javadoc comments to those methods indicating what you are testing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
