hannerwang commented on a change in pull request #2408:
URL: https://github.com/apache/calcite/pull/2408#discussion_r621760976
##########
File path: core/src/test/java/org/apache/calcite/test/SqlToRelConverterTest.java
##########
@@ -371,7 +372,8 @@ public final Sql sql(String sql) {
}
@Test void testAliasInHaving() {
- sql("select count(empno) as e from emp having e > 1")
+ sql("select ename, count(empno) as e, count(deptno) as d from emp"
+ + " group by ename having e > 1 and count(deptno) > 2")
Review comment:
yes, that conforms SOLID, but the commit is fixing the existing
feature, so I choose to change the obsolete tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
