vlsi commented on a change in pull request #2413:
URL: https://github.com/apache/calcite/pull/2413#discussion_r632340367
##########
File path:
core/src/main/java/org/apache/calcite/rel/type/RelDataTypeFactoryImpl.java
##########
@@ -257,6 +260,52 @@ private RelDataType createStructType(
return createTypeWithNullability(builder.build(), isNullable);
}
+ protected @Nullable RelDataType leastRestrictiveArrayMultisetType(
+ final List<RelDataType> types, SqlTypeName sqlTypeName) {
+ assert sqlTypeName == SqlTypeName.ARRAY || sqlTypeName ==
SqlTypeName.MULTISET;
+ boolean isNullable = false;
+ for (RelDataType type: types) {
+ if (type.getComponentType() == null) {
+ return null;
+ }
+ isNullable |= type.isNullable();
+ }
+ final RelDataType type = leastRestrictive(
+ Util.transform(types,
+ t -> t instanceof ArraySqlType
+ ? ((ArraySqlType) t).getComponentType()
+ : ((MultisetSqlType) t).getComponentType()));
+ if (type == null) {
+ return null;
+ }
+ return sqlTypeName == SqlTypeName.ARRAY
+ ? new ArraySqlType(type, isNullable)
+ : new MultisetSqlType(type, isNullable);
+ }
+
+ protected @Nullable RelDataType leastRestrictiveMapType(
+ final List<RelDataType> types, SqlTypeName sqlTypeName) {
+ assert sqlTypeName == SqlTypeName.MAP;
+ boolean isNullable = false;
+ for (RelDataType type: types) {
+ if (type.getKeyType() == null || type.getValueType() == null) {
Review comment:
```suggestion
if (!(type instanceof MapSqlType) || type.getKeyType() == null ||
type.getValueType() == null) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
