danny0405 commented on pull request #2426:
URL: https://github.com/apache/calcite/pull/2426#issuecomment-855750032
> Hi @danny0405,
> thanks for your review. This feature will not be used inside HANA. We are
building a project, which reads analytical data from several sources using
calcite. One of those sources is SAP HANA. Calcite is ideal for this type of
application. It works really fine.
There is a test error, seems caused by the `instanceOf` check, can you take
a look ?
```java
[BadInstanceof] `e` is an instance of TableScan which is a subtype of
Hintable, so this is equivalent to a null check.
if (e instanceof Hintable) {
^
(see https://errorprone.info/bugpattern/BadInstanceof)
Did you mean 'if (e != null) {'?
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
