zinking commented on a change in pull request #2436:
URL: https://github.com/apache/calcite/pull/2436#discussion_r651684547
##########
File path:
core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java
##########
@@ -1553,15 +1553,7 @@ protected boolean isSubstituteRule(VolcanoRuleCall
match) {
*/
@API(since = "1.24", status = API.Status.EXPERIMENTAL)
protected boolean isTransformationRule(VolcanoRuleCall match) {
- if (match.getRule() instanceof SubstitutionRule) {
- return true;
- }
- if (match.getRule() instanceof ConverterRule
- && match.getRule().getOutTrait() == rootConvention) {
- return false;
- }
- return match.getRule().getOperand().trait == Convention.NONE
- || match.getRule().getOperand().trait == null;
+ return match.getRule() instanceof TransformationRule;
Review comment:
I can roughly grasp what is happening after reading the mail
can we add some comments here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
